[all-commits] [llvm/llvm-project] 383329: [mlir] Clear running passes in crashreporter

Jacques Pienaar via All-commits all-commits at lists.llvm.org
Wed Dec 21 11:43:17 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 383329b3a8881bda8d5989439d37b75a5f732f5f
      https://github.com/llvm/llvm-project/commit/383329b3a8881bda8d5989439d37b75a5f732f5f
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2022-12-21 (Wed, 21 Dec 2022)

  Changed paths:
    M mlir/lib/Pass/PassCrashRecovery.cpp

  Log Message:
  -----------
  [mlir] Clear running passes in crashreporter

Clear active contexts and running passes whenever finalizing crash
report message. Ran into segfault where a failure in dynamic pipeline
resulted in querying a pass whose passmanager had already been destroyed
come time for creating summary of running passes. Conservatively clear
both running states as I don't think there is recovery intended from
pass pipeline failure.

Additionally restrict to one reproducer per report - else we end up
clobbering the same reproducer file over and over again. So instead of
ending with last reproducer we now end up with the first reproducer
while not creating and clobbering reproducers over and over again.

Differential Revision: https://reviews.llvm.org/D140488




More information about the All-commits mailing list