[all-commits] [llvm/llvm-project] d483d4: [lldb] Prevent false positives with simple templat...

aeubanks via All-commits all-commits at lists.llvm.org
Tue Dec 20 10:10:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d483d488ca5d04534105b67d83f3c16d142e7a05
      https://github.com/llvm/llvm-project/commit/d483d488ca5d04534105b67d83f3c16d142e7a05
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M lldb/include/lldb/Symbol/CompilerType.h
    M lldb/include/lldb/Symbol/Type.h
    M lldb/include/lldb/Symbol/TypeSystem.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
    M lldb/source/Symbol/CompilerType.cpp
    M lldb/source/Symbol/Type.cpp
    M lldb/source/Symbol/TypeSystem.cpp
    A lldb/test/API/lang/cpp/unique-types4/Makefile
    A lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py
    A lldb/test/API/lang/cpp/unique-types4/main.cpp

  Log Message:
  -----------
  [lldb] Prevent false positives with simple template names in SymbolFileDWARF::FindTypes

The provided test case was crashing because of confusion attempting to find types for `ns::Foo` under -gsimple-template-names. (This looks broken normally because it's attempting to find `ns::Foo` rather than `ns::Foo<T>`)

Looking up types can't give false positives, as opposed to looking up functions as mentioned in https://reviews.llvm.org/D137098.

Reviewed By: Michael137

Differential Revision: https://reviews.llvm.org/D140240




More information about the All-commits mailing list