[all-commits] [llvm/llvm-project] a685bb: [DebugInfo] Unify location selection logic for val...

[Stephen Tozer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a685bb8e333e711d7496f59589694c460f981062
      https://github.com/llvm/llvm-project/commit/a685bb8e333e711d7496f59589694c460f981062
  Author: Stephen Tozer <Stephen.Tozer at Sony.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
    M llvm/test/DebugInfo/MIR/X86/live-debug-values-restore.mir

  Log Message:
  -----------
  [DebugInfo] Unify location selection logic for values in InstrRefBasedImpl

Currently the instruction referencing live debug values has 3 separate
places where we iterate over all known locations to find the best machine
location for a set of values at a given point in the program. Each of these
places has an implementation of this check, and one of them has slightly
different logic to the others. This patch moves the check for the "quality"
of a machine location into a separate function, which also avoids repeatedly
calling expensive functions, giving a slight performance improvement.

Differential Revision: https://reviews.llvm.org/D140412