[all-commits] [llvm/llvm-project] 3a8e00: Revert "Reland "[SimplifyCFG] `FoldBranchToCommonD...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Tue Dec 20 07:37:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a8e009f97d2ed4b751365e514e0bf7131c7ab11
      https://github.com/llvm/llvm-project/commit/3a8e009f97d2ed4b751365e514e0bf7131c7ab11
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/Utils/SimplifyCFG.cpp
    M llvm/test/CodeGen/AArch64/rm_redundant_cmp.ll
    M llvm/test/CodeGen/AArch64/tailmerging_in_mbp.ll
    M llvm/test/CodeGen/AArch64/typepromotion-cost.ll
    M llvm/test/CodeGen/PowerPC/ppc-ctr-dead-code.ll
    M llvm/test/CodeGen/PowerPC/pr48527.ll
    M llvm/test/CodeGen/X86/loop-search.ll
    M llvm/test/Transforms/InstCombine/unused-nonnull.ll
    M llvm/test/Transforms/LICM/hoist-phi.ll
    M llvm/test/Transforms/LICM/sinking.ll
    M llvm/test/Transforms/LoopStrengthReduce/AArch64/small-constant.ll
    M llvm/test/Transforms/LoopUnroll/runtime-loop-multiple-exits.ll
    M llvm/test/Transforms/LoopUnroll/scevunroll.ll
    M llvm/test/Transforms/LoopUnroll/unroll-after-peel.ll
    M llvm/test/Transforms/LoopUnroll/unroll-header-exiting-with-phis-multiple-exiting-blocks.ll
    M llvm/test/Transforms/SimplifyCFG/2008-07-13-InfLoopMiscompile.ll
    M llvm/test/Transforms/SimplifyCFG/X86/SpeculativeExec.ll
    M llvm/test/Transforms/SimplifyCFG/X86/switch_to_lookup_table.ll
    M llvm/test/Transforms/SimplifyCFG/fold-branch-to-common-dest-phis.ll
    M llvm/test/Transforms/SimplifyCFG/fold-branch-to-common-dest.ll
    M llvm/test/Transforms/SimplifyCFG/hoist-dbgvalue.ll
    M llvm/test/Transforms/SimplifyCFG/switch-on-const-select.ll

  Log Message:
  -----------
  Revert "Reland "[SimplifyCFG] `FoldBranchToCommonDest()`: deal with mismatched IV's in PHI's in common successor block""

One of these two changes is exposing (or causing) some more miscompiles.
A reproducer is in progress, so reverting until resolved.

This reverts commit 428f36401b1b695fd501ebfdc8773bed8ced8d4e.


  Commit: d73383c145ea83d25063246e0c34f5a41fd35293
      https://github.com/llvm/llvm-project/commit/d73383c145ea83d25063246e0c34f5a41fd35293
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-20 (Tue, 20 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
    M llvm/test/Transforms/InstCombine/nested-select.ll
    M llvm/test/Transforms/InstCombine/select-factorize.ll

  Log Message:
  -----------
  Revert "[InstCombine] Fold nested selects"

One of these two changes is exposing (or causing) some more miscompiles.
A reproducer is in progress, so reverting until resolved.

This reverts commit 9ddff66d0c9c3e18d56e6b20aa26a2a8cdfb6d2b.


Compare: https://github.com/llvm/llvm-project/compare/015f8cd78ec6...d73383c145ea


More information about the All-commits mailing list