[all-commits] [llvm/llvm-project] 8ef5da: [WebAssembly] Fix crash when selecting 64 bit lane...

Luke Lau via All-commits all-commits at lists.llvm.org
Mon Dec 19 02:37:52 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ef5da701003649d3d31c3b3aa299fba30e4a4b3
      https://github.com/llvm/llvm-project/commit/8ef5da701003649d3d31c3b3aa299fba30e4a4b3
  Author: Luke Lau <luke at igalia.com>
  Date:   2022-12-19 (Mon, 19 Dec 2022)

  Changed paths:
    M llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
    A llvm/test/CodeGen/WebAssembly/simd-extract64.ll

  Log Message:
  -----------
  [WebAssembly] Fix crash when selecting 64 bit lane extract operand

The tablegen patterns on vector_extract only match i32 constants, but
on wasm64 these come in as i64 constants. In certain situations this
would cause crashes whenever it couldn't select an extract_vector_elt
instruction.
Rather than add duplicate patterns for every instruction, this just
canonicalizes the constant to be i32 when lowering.
Fixes https://github.com/llvm/llvm-project/issues/57577

Differential Revision: https://reviews.llvm.org/D140205




More information about the All-commits mailing list