[all-commits] [llvm/llvm-project] 012a85: AMDGPU/GlobalISel: Use ptrtoint to legalize consta...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sun Dec 18 10:16:30 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 012a85296b2fc2fe46b0fd90f4c4f7e5d68e5354
      https://github.com/llvm/llvm-project/commit/012a85296b2fc2fe46b0fd90f4c4f7e5d68e5354
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-addrspacecast.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-load-constant-32bit.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sextload-constant-32bit.mir
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-zextload-constant-32bit.mir
    M llvm/test/CodeGen/AMDGPU/addrspacecast.gfx6.ll

  Log Message:
  -----------
  AMDGPU/GlobalISel: Use ptrtoint to legalize constant 32-bit addrspacecast

This was trying to merge 2 32-bit pointers into a 64-bit pointer. The
artifact combiner was assuming merges to pointers use scalar sources,
and ended up inserting invalid bitcast from a pointer to a scalar. It
should probably be a verifier error to have pointer merge sources with
a pointer result.

Fixes verifier errors with EXPENSIVE_CHECKS.




More information about the All-commits mailing list