[all-commits] [llvm/llvm-project] dbc76e: [NFC][llvm-exegesis] Benchmark: move DumpObjectToD...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Sun Dec 18 06:52:26 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dbc76ef7915f925970f7bae1c5b79f3dcf55d85e
      https://github.com/llvm/llvm-project/commit/dbc76ef7915f925970f7bae1c5b79f3dcf55d85e
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  [NFC][llvm-exegesis] Benchmark: move DumpObjectToDisk handling into `runConfiguration()`

`getRunnableConfiguration()` may be executed in parallel,
and then this the output would become even less useful.


  Commit: 18da9a0cb35c3849e47625272e477dbc5544e25b
      https://github.com/llvm/llvm-project/commit/18da9a0cb35c3849e47625272e477dbc5544e25b
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/test/tools/llvm-exegesis/X86/latency/latency-CMOV32rr.s
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  [llvm-exegesis] Fix 'min' repetition mode in presence of missing measurements

This was a regression from 17e202424c021fd903950fec7a8b6cca2d83abce.
Previously we'd gracefully handle missing measurements,
but that handling got accidentally lost during the code move,
and we'd assert.

What we want to do, is to discard all measurements (from all repetitors
in a given config) if any of them failed, but do append the snippet,
and do emit the empty measurement.


Compare: https://github.com/llvm/llvm-project/compare/ba57d2ad4e9a...18da9a0cb35c


More information about the All-commits mailing list