[all-commits] [llvm/llvm-project] 8d81fe: [InstCombine] avoid IR values named 'tmp' in tests...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Sun Dec 18 04:10:10 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d81fe3adbf83629ce2d0508f3a0bd1a6f029b07
      https://github.com/llvm/llvm-project/commit/8d81fe3adbf83629ce2d0508f3a0bd1a6f029b07
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/insert-extract-shuffle-inseltpoison.ll
    M llvm/test/Transforms/InstCombine/insert-extract-shuffle.ll

  Log Message:
  -----------
  [InstCombine] avoid IR values named 'tmp' in tests; NFC

The auto-generation CHECK script warns of possible conflict on these files.


  Commit: 9ec5b512b67013f0b78460061a6c984a709f423f
      https://github.com/llvm/llvm-project/commit/9ec5b512b67013f0b78460061a6c984a709f423f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/add.ll

  Log Message:
  -----------
  [InstCombine] add tests for flooring division; NFC

issue #57741


  Commit: d5f8878a6e7db01004a3bf61f6b6efbb7d5add25
      https://github.com/llvm/llvm-project/commit/d5f8878a6e7db01004a3bf61f6b6efbb7d5add25
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp
    M llvm/test/Transforms/InstCombine/broadcast-inseltpoison.ll
    M llvm/test/Transforms/InstCombine/broadcast.ll
    M llvm/test/Transforms/InstCombine/insert-extract-shuffle-inseltpoison.ll
    M llvm/test/Transforms/InstCombine/insert-extract-shuffle.ll
    M llvm/test/Transforms/InstCombine/insertelt-trunc.ll
    M llvm/test/Transforms/InstCombine/vec_shuffle-inseltpoison.ll
    M llvm/test/Transforms/InstCombine/vec_shuffle.ll
    M llvm/test/Transforms/PhaseOrdering/X86/vector-reductions.ll

  Log Message:
  -----------
  [InstCombine] canonicalize insertelement order based on index

This puts lower insert indexes before higher. This is independent
of endian, so it requires an adjustment to a fold added with
4446f71ce392, but it makes that fold more robust.
That's also where this patch was suggested - D139668.

This matches what we already do in DAGCombiner, but there is one
more constraint because there's an existing canonicalization for
insert-of-scalar-constant. I'm not sure if that is still needed,
so it may be adjusted/removed as a follow-up.


Compare: https://github.com/llvm/llvm-project/compare/c365fdd8d53c...d5f8878a6e7d


More information about the All-commits mailing list