[all-commits] [llvm/llvm-project] a5de49: [NFC][llvm-exegesis] `InstructionBenchmark`: only ...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Sat Dec 17 17:23:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a5de49755cab6ccea9380f7f51a133d2e37cdc88
      https://github.com/llvm/llvm-project/commit/a5de49755cab6ccea9380f7f51a133d2e37cdc88
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkResult.h
    M llvm/unittests/tools/llvm-exegesis/Mips/BenchmarkResultTest.cpp
    M llvm/unittests/tools/llvm-exegesis/X86/BenchmarkResultTest.cpp

  Log Message:
  -----------
  [NFC][llvm-exegesis] `InstructionBenchmark`: only allow move constructor

We don't ever legitimately need to copy it, so let's make that explicit


  Commit: 1dd4a6aac6498c6ebdcfcc3da0beb440e4650b20
      https://github.com/llvm/llvm-project/commit/1dd4a6aac6498c6ebdcfcc3da0beb440e4650b20
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  [NFC][llvm-exegesis] `BenchmarkRunner`: split `runConfiguration()` into `getRunnableConfiguration()` + `runConfiguration()`

We can run as many `getRunnableConfiguration()` in parallel as we want,
but `runConfiguration()` must be run *completely* standalone from everything.
This is a step towards enabling threading.


  Commit: 81b35aa69f99d4dec7b836a52eb941075b61a384
      https://github.com/llvm/llvm-project/commit/81b35aa69f99d4dec7b836a52eb941075b61a384
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-18 (Sun, 18 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  [NFC][llvm-exegesis] Extract `runBenchmarkConfigurations()` out of `benchmarkMain()`

`benchmarkMain()` is already bigger than it should be,
let's extract the important chunk before making it even larger.


Compare: https://github.com/llvm/llvm-project/compare/fbaf48be0ff6...81b35aa69f99


More information about the All-commits mailing list