[all-commits] [llvm/llvm-project] 17e202: [NFCI][llvm-exegesis] Extract 'Min' repetition han...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Sat Dec 17 12:15:18 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 17e202424c021fd903950fec7a8b6cca2d83abce
      https://github.com/llvm/llvm-project/commit/17e202424c021fd903950fec7a8b6cca2d83abce
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h
    M llvm/tools/llvm-exegesis/llvm-exegesis.cpp

  Log Message:
  -----------
  [NFCI][llvm-exegesis] Extract 'Min' repetition handling from `BenchmarkRunner` into it's caller

If `BenchmarkRunner::runConfiguration()` deals with more than a single
repetitor, tasking will be less straight-forward to implement.
But i think dealing with that in it's callee is even more readable.


  Commit: 0db620aa30c9b45086add91a7202ca473bb50907
      https://github.com/llvm/llvm-project/commit/0db620aa30c9b45086add91a7202ca473bb50907
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp

  Log Message:
  -----------
  [NFC][llvm-exegesis] `BenchmarkRunner::runConfiguration()`: reformat


  Commit: 41dd767fee7508ac57c8783e401abc04f95e4e0f
      https://github.com/llvm/llvm-project/commit/41dd767fee7508ac57c8783e401abc04f95e4e0f
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h

  Log Message:
  -----------
  [NFC][llvm-exegesis] `BenchmarkRunner::runConfiguration()`: deduplicate `DumpObjectToDisk` handling

Always assemble into buffer, that is then optionally dumped into file.


  Commit: 118b49a09b9759d8d2e4171fdd2ad2784a6e4148
      https://github.com/llvm/llvm-project/commit/118b49a09b9759d8d2e4171fdd2ad2784a6e4148
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.h

  Log Message:
  -----------
  [NFCI][llvm-exegesis] `BenchmarkRunner::runConfiguration()`: extract `assembleSnippet()` helper


Compare: https://github.com/llvm/llvm-project/compare/b57533d1d5a2...118b49a09b97


More information about the All-commits mailing list