[all-commits] [llvm/llvm-project] 4913e5: [mlir] std::optional::value => operator*/operator->

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4913e5da3c2a73b14bf1b26902920003177948b9
      https://github.com/llvm/llvm-project/commit/4913e5da3c2a73b14bf1b26902920003177948b9
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M mlir/lib/AsmParser/AttributeParser.cpp
    M mlir/lib/Conversion/ComplexToLibm/ComplexToLibm.cpp
    M mlir/lib/Dialect/Affine/Analysis/LoopAnalysis.cpp
    M mlir/lib/Dialect/Affine/Transforms/LoopFusion.cpp
    M mlir/lib/TableGen/AttrOrTypeDef.cpp
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/lib/Transforms/Inliner.cpp
    M mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-yaml-gen.cpp

  Log Message:
  -----------
  [mlir] std::optional::value => operator*/operator->

value() has undesired exception checking semantics and calls
__throw_bad_optional_access in libc++. Moreover, the API is unavailable without
_LIBCPP_NO_EXCEPTIONS on older Mach-O platforms (see
_LIBCPP_AVAILABILITY_BAD_OPTIONAL_ACCESS).