[all-commits] [llvm/llvm-project] eec575: Allow non-constant divisors in affine mod, floordi...

[bjacob via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eec575e548d114d96acb673ccb9b8a1ef795465b
      https://github.com/llvm/llvm-project/commit/eec575e548d114d96acb673ccb9b8a1ef795465b
  Author: Benoit Jacob <benoitjacob at google.com>
  Date:   2022-12-17 (Sat, 17 Dec 2022)

  Changed paths:
    M mlir/lib/Dialect/Affine/Utils/Utils.cpp
    M mlir/test/Conversion/AffineToStandard/lower-affine.mlir

  Log Message:
  -----------
  Allow non-constant divisors in affine mod, floordiv, ceildiv.

The requirement that divisor>0 is not enforced here outside of the
constant case, but how to enforce it? If I understand correctly, it is
UB and while it is nice to be able to deterministically intercept UB,
that isn't always feasible. Hopefully, keeping the existing
enforcement in the constant case is enough.

Differential Revision: https://reviews.llvm.org/D140079