[all-commits] [llvm/llvm-project] 2fa744: std::optional::value => operator*/operator->

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fa744e631cbabe583da010ec56560edbc7a5384
      https://github.com/llvm/llvm-project/commit/2fa744e631cbabe583da010ec56560edbc7a5384
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-12-16 (Fri, 16 Dec 2022)

  Changed paths:
    M llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h
    M llvm/include/llvm/Analysis/VectorUtils.h
    M llvm/include/llvm/Bitstream/BitstreamWriter.h
    M llvm/include/llvm/IR/IRBuilder.h
    M llvm/include/llvm/MC/MCSymbolWasm.h
    M llvm/include/llvm/MC/MCSymbolXCOFF.h
    M llvm/include/llvm/Support/Casting.h
    M llvm/lib/Analysis/BranchProbabilityInfo.cpp
    M llvm/lib/Analysis/IRSimilarityIdentifier.cpp
    M llvm/lib/Analysis/InlineCost.cpp
    M llvm/lib/Analysis/InstructionSimplify.cpp
    M llvm/lib/Analysis/LazyValueInfo.cpp
    M llvm/lib/Analysis/MemoryBuiltins.cpp
    M llvm/lib/Analysis/MustExecute.cpp
    M llvm/lib/Analysis/ProfileSummaryInfo.cpp
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/lib/Analysis/VectorUtils.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/lib/IR/DebugInfo.cpp
    M llvm/lib/IR/Instructions.cpp
    M llvm/lib/IR/IntrinsicInst.cpp
    M llvm/lib/IR/LLVMContextImpl.cpp
    M llvm/lib/InterfaceStub/IFSHandler.cpp
    M llvm/lib/MC/MCAsmStreamer.cpp
    M llvm/lib/MC/MCContext.cpp
    M llvm/lib/MC/MCDisassembler/MCDisassembler.cpp
    M llvm/lib/MC/MCParser/MasmParser.cpp
    M llvm/lib/MC/MCSchedule.cpp
    M llvm/lib/MC/MCSectionXCOFF.cpp
    M llvm/lib/Object/ELFObjectFile.cpp
    M llvm/lib/Support/Process.cpp
    M llvm/lib/Support/VirtualFileSystem.cpp
    M llvm/lib/Support/raw_ostream.cpp
    M llvm/lib/TableGen/Record.cpp
    M llvm/unittests/FileCheck/FileCheckTest.cpp
    M llvm/unittests/Support/AlignmentTest.cpp
    M llvm/unittests/Support/KnownBitsTest.cpp
    M llvm/utils/TableGen/GlobalISelEmitter.cpp

  Log Message:
  -----------
  std::optional::value => operator*/operator->

value() has undesired exception checking semantics and calls
__throw_bad_optional_access in libc++. Moreover, the API is unavailable without
_LIBCPP_NO_EXCEPTIONS on older Mach-O platforms (see
_LIBCPP_AVAILABILITY_BAD_OPTIONAL_ACCESS).

This commit fixes LLVMAnalysis and its dependencies.