[all-commits] [llvm/llvm-project] 942808: Revert "[WindowsDriver] Improve VSInstallPath che...

[Dimitry Andric via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9428084a20a8334414dc8573b54d2c9a8748ce4b
      https://github.com/llvm/llvm-project/commit/9428084a20a8334414dc8573b54d2c9a8748ce4b
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M llvm/lib/WindowsDriver/MSVCPaths.cpp

  Log Message:
  -----------
  Revert "[WindowsDriver]  Improve VSInstallPath check for IDE subdirectory"

This reverts commit cc40dacbd0b736522d0254fb5525cde22bd5f166.


  Commit: 2a48c5f5d597002b7e315126c69672bc11185d90
      https://github.com/llvm/llvm-project/commit/2a48c5f5d597002b7e315126c69672bc11185d90
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M llvm/lib/WindowsDriver/MSVCPaths.cpp

  Log Message:
  -----------
  [WindowsDriver] Improve VSInstallPath check for IDE subdirectory

This avoids potential memory allocation failures, if VSInstallPath is
not empty, but also does not contain the string "\Common7\IDE".

Fixes: https://github.com/llvm/llvm-project/issues/59434

Reviewed By: mstorsjo

Differential Revision: https://reviews.llvm.org/D140019


Compare: https://github.com/llvm/llvm-project/compare/cc40dacbd0b7...2a48c5f5d597