[all-commits] [llvm/llvm-project] aa0049: [NFC] [C++20] [Modules] Add merge-records test for...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Wed Dec 14 23:33:29 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aa00493de2b3c3a1819497ad36b8262be12e40bb
      https://github.com/llvm/llvm-project/commit/aa00493de2b3c3a1819497ad36b8262be12e40bb
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    A clang/test/Modules/merge-records.cppm

  Log Message:
  -----------
  [NFC] [C++20] [Modules] Add merge-records test for C++20 Modules

Merging declarations and checking ODR violations are a big part in the
implementation of modules. Currently, the implementation of C++20
Modules share a big part with the Clang modules and the ObjC modules for
the clang's serializer/deserailizer.

This is good. We saved a lot of time by this. And a lot of C++20
Modules's codes can run due to reuse it. However, the bad side is that
we lack a lot of tests about merging declarations and ODR checks for
C++20 Modules. It is not stable on the long run. So the patch tries to
add a test for it. This should be a long-term goal for C++20 modules.
(To add the test we shoudl add).




More information about the All-commits mailing list