[all-commits] [llvm/llvm-project] b05b89: [mlir][gpu][spirv] Verify elementwise op type as m...

Quinn Dawkins via All-commits all-commits at lists.llvm.org
Wed Dec 14 19:16:24 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b05b8970d8b35e0ffcdab1a77e8be836c0aaae70
      https://github.com/llvm/llvm-project/commit/b05b8970d8b35e0ffcdab1a77e8be836c0aaae70
  Author: Quinn Dawkins <quinn at nod-labs.com>
  Date:   2022-12-15 (Thu, 15 Dec 2022)

  Changed paths:
    M mlir/lib/Conversion/GPUToSPIRV/WmmaOpsToSPIRV.cpp
    M mlir/test/Conversion/GPUToSPIRV/wmma-ops-to-spirv.mlir

  Log Message:
  -----------
  [mlir][gpu][spirv] Verify elementwise op type as mulf when converting to spirv.MatrixTimesScalar

Conversion from gpu.subgroup_mma_constant_matrix to spirv.MatrixTimesScalar didn't check that the op type was a multiplication and thus would incorrectly convert other elementwise scalar operations.

Reviewed By: ThomasRaoux

Differential Revision: https://reviews.llvm.org/D140081




More information about the All-commits mailing list