[all-commits] [llvm/llvm-project] 940816: [FileCheck] llvm::Optional => std::optional

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Dec 14 10:44:44 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9408164254d26d5305fe4e0267b668c41c1266ed
      https://github.com/llvm/llvm-project/commit/9408164254d26d5305fe4e0267b668c41c1266ed
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M llvm/lib/FileCheck/FileCheck.cpp
    M llvm/lib/FileCheck/FileCheckImpl.h
    M llvm/unittests/FileCheck/FileCheckTest.cpp

  Log Message:
  -----------
  [FileCheck] llvm::Optional => std::optional

Don't touch FileCheck.cpp:698 StringSwitch<Optional<binop_eval_t>>(FuncName).
MSVC and older GCC may report errors:

error C2664: 'llvm::StringSwitch<std::optional<llvm::binop_eval_t>,T> &llvm::StringSwitch<T,T>::Case(llvm::StringLiteral,T)': cannot convert argument 2 from 'overloaded-function' to 'T'
        with
        [
            T=std::optional<llvm::binop_eval_t>
        ]

llvm/lib/FileCheck/FileCheck.cpp:699:44: error: no matching function for call to ‘llvm::StringSwitch<std::optional<llvm::Expected<llvm::ExpressionValue> (*)(const llvm::ExpressionValue&, const llvm::ExpressionValue&)> >::Case(const char [4], <unresolved overloaded function type>)’
                      .Case("add", operator+)
                                            ^




More information about the All-commits mailing list