[all-commits] [llvm/llvm-project] 902e28: [libc++] Refactor .compile.fail.cpp tests for std:...
Louis Dionne via All-commits
all-commits at lists.llvm.org
Wed Dec 14 07:56:31 PST 2022
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: 902e28def669bd3f0f45088fd7793b1f2f58286a
https://github.com/llvm/llvm-project/commit/902e28def669bd3f0f45088fd7793b1f2f58286a
Author: Louis Dionne <ldionne.2 at gmail.com>
Date: 2022-12-14 (Wed, 14 Dec 2022)
Changed paths:
R libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/derive_from.compile.fail.cpp
A libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/derive_from.verify.cpp
R libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/deduct_F.fail.cpp
A libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/deduct_F.verify.cpp
R libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.inv/invoke.compile.fail.cpp
A libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.inv/invoke.verify.cpp
Log Message:
-----------
[libc++] Refactor .compile.fail.cpp tests for std::function
Some of those .compile.fail.cpp tests had become incorrect and they
were not testing anything. In general, .compile.fail.cpp tests are
bad because they make it way too easy to write garbage tests. Indeed,
the test could fail to compile due to any reason whatsoever (even a
typo) and it would appear to work correctly.
Differential Revision: https://reviews.llvm.org/D138731
More information about the All-commits
mailing list