[all-commits] [llvm/llvm-project] e45cf4: [Bitcode] Remove auto-detection for typed pointers

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e45cf479231fc144b4e1eb8b3e3bd2f578b6907d
      https://github.com/llvm/llvm-project/commit/e45cf479231fc144b4e1eb8b3e3bd2f578b6907d
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M llvm/docs/OpaquePointers.rst
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp
    R llvm/test/Bitcode/Inputs/invalid-call-mismatched-explicit-type.bc
    R llvm/test/Bitcode/Inputs/invalid-gep-mismatched-explicit-type.bc
    R llvm/test/Bitcode/Inputs/invalid-gep-operator-mismatched-explicit-type.bc
    R llvm/test/Bitcode/Inputs/invalid-load-mismatched-explicit-type.bc
    M llvm/test/Bitcode/alloca-addrspace.ll
    M llvm/test/Bitcode/arm-intrinsics.ll
    M llvm/test/Bitcode/atomic-no-syncscope.ll
    M llvm/test/Bitcode/atomic.ll
    M llvm/test/Bitcode/atomicrmw-upgrade.ll
    M llvm/test/Bitcode/attributes-3.3.ll
    M llvm/test/Bitcode/byval-upgrade.test
    M llvm/test/Bitcode/callbr.ll
    M llvm/test/Bitcode/cmpxchg-upgrade.ll
    M llvm/test/Bitcode/cmpxchg.3.6.ll
    M llvm/test/Bitcode/compatibility-3.6.ll
    M llvm/test/Bitcode/compatibility-3.7.ll
    M llvm/test/Bitcode/compatibility-3.8.ll
    M llvm/test/Bitcode/compatibility-3.9.ll
    M llvm/test/Bitcode/compatibility-4.0.ll
    M llvm/test/Bitcode/compatibility-5.0.ll
    M llvm/test/Bitcode/compatibility-6.0.ll
    M llvm/test/Bitcode/constantsTest.3.2.ll
    M llvm/test/Bitcode/conversionInstructions.3.2.ll
    M llvm/test/Bitcode/dityperefs-3.8.ll
    M llvm/test/Bitcode/dso_location.ll
    M llvm/test/Bitcode/function-address-space-fwd-decl.ll
    M llvm/test/Bitcode/getelementptr-zero-indices.ll
    M llvm/test/Bitcode/global-variables.3.2.ll
    M llvm/test/Bitcode/highLevelStructure.3.2.ll
    M llvm/test/Bitcode/inalloca-upgrade.test
    M llvm/test/Bitcode/inalloca.ll
    M llvm/test/Bitcode/intrinsics-struct-upgrade.ll
    M llvm/test/Bitcode/intrinsics-with-unnamed-types.ll
    M llvm/test/Bitcode/invalid.test
    M llvm/test/Bitcode/local-linkage-default-visibility.3.4.ll
    M llvm/test/Bitcode/memInstructions.3.2.ll
    M llvm/test/Bitcode/metadata-2.ll
    M llvm/test/Bitcode/metadata.3.5.ll
    M llvm/test/Bitcode/miscInstructions.3.2.ll
    M llvm/test/Bitcode/nocfivalue.ll
    M llvm/test/Bitcode/objectsize-upgrade-7.0.ll
    M llvm/test/Bitcode/old-aliases.ll
    M llvm/test/Bitcode/select.ll
    M llvm/test/Bitcode/standardCIntrinsic.3.2.ll
    M llvm/test/Bitcode/terminatorInstructions.3.2.ll
    M llvm/test/Bitcode/thinlto-function-summary.ll
    M llvm/test/Bitcode/thinlto-summary-local-5.0.ll
    M llvm/test/Bitcode/upgrade-aarch64-ldstxr.ll
    M llvm/test/Bitcode/upgrade-aarch64-sve-intrinsics.ll
    M llvm/test/Bitcode/upgrade-annotation.ll
    M llvm/test/Bitcode/upgrade-arc-attachedcall-bundle.ll
    M llvm/test/Bitcode/upgrade-arc-runtime-calls-bitcast.ll
    M llvm/test/Bitcode/upgrade-arc-runtime-calls.ll
    M llvm/test/Bitcode/upgrade-elementtype.ll
    M llvm/test/Bitcode/upgrade-global-ctors.ll
    M llvm/test/Bitcode/upgrade-global-dtors.ll
    M llvm/test/Bitcode/upgrade-inline-asm-elementtype.ll
    M llvm/test/Bitcode/upgrade-ptr-annotation.ll
    M llvm/test/Bitcode/upgrade-tbaa.ll
    M llvm/test/Bitcode/upgrade-var-annotation.ll
    M llvm/test/Bitcode/variableArgumentIntrinsic.3.2.ll
    M llvm/test/Bitcode/weak-cmpxchg-upgrade.ll

  Log Message:
  -----------
  [Bitcode] Remove auto-detection for typed pointers

Always read bitcode according to the -opaque-pointers mode. Do not
perform auto-detection to implicitly switch to typed pointers.

This is a step towards removing typed pointer support, and also
eliminates the class of problems where linking may fail if a typed
pointer module is loaded before an opaque pointer module. (The
latest place where this was encountered is D139924, but this has
previously been fixed in other places doing bitcode linking as well.)

Differential Revision: https://reviews.llvm.org/D139940