[all-commits] [llvm/llvm-project] 43b5fb: Revert "[InstCombine] Handle logical op in simplif...

Nikita Popov via All-commits all-commits at lists.llvm.org
Wed Dec 14 03:04:38 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43b5fbae3b00ff9dc11e5d102aad3a80be9f5067
      https://github.com/llvm/llvm-project/commit/43b5fbae3b00ff9dc11e5d102aad3a80be9f5067
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
    M llvm/lib/Transforms/InstCombine/InstCombineInternal.h
    M llvm/test/Transforms/InstCombine/pr49688.ll
    M llvm/test/Transforms/InstCombine/range-check.ll

  Log Message:
  -----------
  Revert "[InstCombine] Handle logical op in simplifyRangeCheck() (PR59484)"

This reverts commit 492c471839a66e354ebe696bd3e15f7477c63613.

As pointed out by nloped, the transform in f2 is not correct: If
%shr is poison, then freeze may result in a negative value. The
transform is correct in the case where the freeze is pushed through
the operation in a way that guarantees the result is non-negative,
which is the case I had tested.




More information about the All-commits mailing list