[all-commits] [llvm/llvm-project] 3674ca: [mlir][llvm] Fix bug in the LLVM IR constant import.

Tobias Gysi via All-commits all-commits at lists.llvm.org
Wed Dec 14 01:32:28 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3674cadf4d6a3390875bd0173470f3a55870edcd
      https://github.com/llvm/llvm-project/commit/3674cadf4d6a3390875bd0173470f3a55870edcd
  Author: Tobias Gysi <tobias.gysi at nextsilicon.com>
  Date:   2022-12-14 (Wed, 14 Dec 2022)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/test/Target/LLVMIR/Import/constant.ll

  Log Message:
  -----------
  [mlir][llvm] Fix bug in the LLVM IR constant import.

The recently introduced iterative constant import
(https://reviews.llvm.org/D137559) fails for programs that
subsequently import constant expressions with duplicate
subexpressions. The reason is a broken duplicate check
in getConstantsToConvert. The revision fixes the bug and
adds a test case that imports two constant expressions
with duplicates.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D139918




More information about the All-commits mailing list