[all-commits] [llvm/llvm-project] d38d60: [mlir][tensor][linalg] Enhance pack op propagation...

Han-Chung Wang via All-commits all-commits at lists.llvm.org
Tue Dec 13 14:06:35 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d38d6065584ee5dd837e9a629f90c731d8a7dffc
  Author: Hanhan Wang <hanchung at google.com>
  Date:   2022-12-13 (Tue, 13 Dec 2022)

  Changed paths:
    M mlir/lib/Dialect/Linalg/Transforms/DataLayoutPropagation.cpp
    M mlir/test/Dialect/Linalg/data-layout-propagation.mlir

  Log Message:
  [mlir][tensor][linalg] Enhance pack op propagation across generic ops.

Considering the case that generic + pack (with outer_dim_perms), the
truth is that it is equipvelent to generic + pack + transpose. There are
two steps to bubble up the pack op accross the generic op.

Step 1. swap generic + pack -> pack + generic.

In this step, we can bind the packing information to dimensions of
iteration domain. With the information, we can pack the operands with
corresponding data tile sizes; the packed inner dimensions will be
appended to the indexing_maps. Note that the outer dimensions of
indexing maps are not changed at all.

Step 2. Fold the transpose into generic op.

The step two is just updating the indexing map, so we do not have to
handle outer_dim_perms anymore.

There could be step 3 to extract the transpose op out (i.e., generic ->
transpose + generic), then we can fold the transpose into the pack op.
This step is not done in the revision.

Co-authored-by: Lorenzo Chelini <l.chelini at icloud.com>

Reviewed By: chelini

Differential Revision: https://reviews.llvm.org/D139680

More information about the All-commits mailing list