[all-commits] [llvm/llvm-project] 021ff5: ObjCARC: Try to fix faulty tests

[Matt Arsenault via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 021ff534bf2a6fd4ccef8bae1b6feb8439a0cc5c
      https://github.com/llvm/llvm-project/commit/021ff534bf2a6fd4ccef8bae1b6feb8439a0cc5c
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M llvm/test/Transforms/ObjCARC/basic.ll

  Log Message:
  -----------
  ObjCARC: Try to fix faulty tests

These were trying to check if there was not an llvm.objc call before a
closing "}", which presumably was intended to match the end of the
function. Really this was matching the closing } in "bitcast {}* %self
to i8*", which can't be what anyone intended. This broke after
converting the test to opaque pointer deleted this bitcast.

There are in fact @llvm.obj calls remaining in the function, so this
may indicate the transform this was intended to check is actually
broken. In @"\01-[A z]" (great test name), the first retain call seems
to move down to the printf. The second case, @"\01-[Top0 _getX]", has
no change.

Change the checks to what's produced and add FIXMES. Also change the }
checks to match only at the start of the line for the function end.