[all-commits] [llvm/llvm-project] 72b2ca: [COFF] Respect weak externals for mangled symbol s...

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Mon Dec 12 10:52:57 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 72b2ca5d0641be5202691728f50ec4b13b5f0634
      https://github.com/llvm/llvm-project/commit/72b2ca5d0641be5202691728f50ec4b13b5f0634
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M lld/COFF/SymbolTable.cpp
    A lld/test/COFF/entry-weak-external.s
    A lld/test/COFF/subsystem-inference-weak-external.s

  Log Message:
  -----------
  [COFF] Respect weak externals for mangled symbol searching

We were previously ignoring weak externals during these searches (which
are used for the entry point, exports, and subsystem inference), which
differed from link.exe behavior. It also meant that we could get
different behavior when linking an object file directly vs. packaging it
into a static library, because static library symbol name directories
include weak externals.

Reviewed By: mstorsjo, yozhu

Differential Revision: https://reviews.llvm.org/D139764




More information about the All-commits mailing list