[all-commits] [llvm/llvm-project] df969f: [mlir] fixes to transform::SequenceOp

ftynse via All-commits all-commits at lists.llvm.org
Mon Dec 12 01:20:53 PST 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: df969f66ef43fea537503369651a12429ba1cde1
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2022-12-12 (Mon, 12 Dec 2022)

  Changed paths:
    M mlir/lib/Dialect/Transform/IR/TransformOps.cpp
    M mlir/test/Dialect/Transform/ops-invalid.mlir

  Log Message:
  [mlir] fixes to transform::SequenceOp

Harden the verifier to check that the block argument type matches the
operand type, when present. This was overlooked when transform dialect
types were introduced.

Fix the builders to preserve the insertion point before creating the
block, otherwise the insertion point is updated to be within the block
by `createBlock` and never reset to be after the sequence op itself,
leading all following operations to be created in the unexpected to
the caller place.

Reviewed By: chelini, springerm

Differential Revision: https://reviews.llvm.org/D139427

More information about the All-commits mailing list