[all-commits] [llvm/llvm-project] aef89c: [mlir] Cleanup lingering problems surrounding attr...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aef89c8b41847c7235e00fbf8b2a2f10cb1aad25
      https://github.com/llvm/llvm-project/commit/aef89c8b41847c7235e00fbf8b2a2f10cb1aad25
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/AsmParser/LocationParser.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/Dialect/DLTI/roundtrip.mlir
    M mlir/test/Dialect/SparseTensor/sparse_vector_chain.mlir
    M mlir/test/Dialect/SparseTensor/sparse_vector_index.mlir
    M mlir/test/IR/pretty-locations.mlir
    M mlir/test/IR/print-attr-type-aliases.mlir
    M mlir/test/Target/LLVMIR/Import/debug-info.ll

  Log Message:
  -----------
  [mlir] Cleanup lingering problems surrounding attribute/type aliases

This commit refactors attribute/type alias generation to be similar to how
we do it for operations, i.e. we generate aliases determined on what is
actually necessary when printing the IR (using a dummy printer for alias
collection). This allows for generating aliases only when necessary, and
also allows for proper propagation of when a nested alias can be deferred.
This also necessitated a fix for location parsing to actually parse aliases
instead of ignoring them.

Fixes #59041

Differential Revision: https://reviews.llvm.org/D138886


  Commit: b3cf9066de9386857fcadcd62fe4cc2f38bfd044
      https://github.com/llvm/llvm-project/commit/b3cf9066de9386857fcadcd62fe4cc2f38bfd044
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M mlir/include/mlir/IR/AsmState.h

  Log Message:
  -----------
  [mlir] Update HeapAsmResourceBlob::allocate API to make alignment explicit

This effectively matches the same API changes that were made to
UnmanagedAsmResourceBlob.


Compare: https://github.com/llvm/llvm-project/compare/658a5039373e...b3cf9066de93