[all-commits] [llvm/llvm-project] 4eb845: [runtimes] Fix runtimes-test-depends

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Wed Nov 30 16:57:43 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4eb84582344f97167b6a2b4cb1fb1d75ae07897e
      https://github.com/llvm/llvm-project/commit/4eb84582344f97167b6a2b4cb1fb1d75ae07897e
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Fix runtimes-test-depends

The dependency list is stored in a global property, so we need to fetch
it to a variable before using that variable. We also need to add the
list contents as dependencies correctly.


  Commit: 658a5039373e3272e9920a07312a013c2f629538
      https://github.com/llvm/llvm-project/commit/658a5039373e3272e9920a07312a013c2f629538
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M clang/lib/Driver/ToolChain.cpp
    M clang/test/Driver/stdlibxx-isystem.cpp

  Log Message:
  -----------
  [Driver] Only check -nostdinc++ for -stdlib++-isystem

A drive-by change in 53c98d85a8a609552448043d5512e70313b1eb1b made
-stdlib++-isystem be suppressed by -nostdinc and -nostdlibinc in
addition to -nostdinc++. However, that's contrary to the intent of the
flag. It's common to provide your own C++ headers (e.g. when building
libc++ by itself or as a compiler-rt dependency) but rely on the system
C headers, and having -stdlib++-isystem only look at -nostdinc++ allows
us to customize both the C header path (via -nostdinc or -nostdlibinc)
and the C++ header path (via -stdlib++-isystem) at the toolchain level
but still let users of the toolchain provide their own C++ headers. Add
a comment explaining the rationale to make it clearer.


Compare: https://github.com/llvm/llvm-project/compare/de7222b2ddfc...658a5039373e


More information about the All-commits mailing list