[all-commits] [llvm/llvm-project] d3714c: [include-cleaner] Move RecordedPP::RecordedInclude...

Sam McCall via All-commits all-commits at lists.llvm.org
Wed Nov 30 09:16:16 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d3714c2b277ac649374ada6dacf20c7a1ba9120c
      https://github.com/llvm/llvm-project/commit/d3714c2b277ac649374ada6dacf20c7a1ba9120c
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h
    M clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h
    M clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
    M clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
    M clang-tools-extra/include-cleaner/lib/Record.cpp
    M clang-tools-extra/include-cleaner/lib/Types.cpp
    M clang-tools-extra/include-cleaner/unittests/CMakeLists.txt
    M clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
    A clang-tools-extra/include-cleaner/unittests/TypesTest.cpp

  Log Message:
  -----------
  [include-cleaner] Move RecordedPP::RecordedIncludes -> Includes in Types.h. NFC

Requiring everything that wants to match Includes to depend on Record is weird.
This isn't lightweight enough that it feels perfect in Types, could be its own
header instead. But pragmatically it doesn't add bad deps, and is widely used.

Differential Revision: https://reviews.llvm.org/D139014




More information about the All-commits mailing list