[all-commits] [llvm/llvm-project] 6a95e6: [include-cleaner] HTMLReport shows headers that wo...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri Nov 25 02:57:50 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6a95e67323dd64e6023c0b5ea89407cac2dbc01b
      https://github.com/llvm/llvm-project/commit/6a95e67323dd64e6023c0b5ea89407cac2dbc01b
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-11-25 (Fri, 25 Nov 2022)

  Changed paths:
    M clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
    M clang-tools-extra/include-cleaner/lib/HTMLReport.cpp
    M clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp

  Log Message:
  -----------
  [include-cleaner] HTMLReport shows headers that would be inserted

Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/9730f933a2cf2e003365520b6636f731/raw/7911d8251ceab7c244e0510285105027cd0a9403/PathMapping.cpp.html

Header insertion doesn't actually work that well (not this patch's fault):
- we don't have ranking of locations/headers yet, so inserted header is pretty
  random
- on my system, we get a lot of absolute "/usr/bin/../include/..." paths.
  This is a HeaderSearch bug introduced in D60873 that I'll send a fix for

Differential Revision: https://reviews.llvm.org/D138676




More information about the All-commits mailing list