[all-commits] [llvm/llvm-project] c4c0e7: [libcxx] Add _LIBCPP_NODEBUG to std::conditional r...

[David Blaikie via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c4c0e7984ffdef8820eab3e66863e9a598d1d2ef
      https://github.com/llvm/llvm-project/commit/c4c0e7984ffdef8820eab3e66863e9a598d1d2ef
  Author: David Blaikie <dblaikie at gmail.com>
  Date:   2022-11-22 (Tue, 22 Nov 2022)

  Changed paths:
    M libcxx/include/__type_traits/conditional.h

  Log Message:
  -----------
  [libcxx] Add _LIBCPP_NODEBUG to std::conditional related typedfs

Looks like std::conditional wasn't included in 14d4869209cc8ff9a53aaa5a59d6409fbc1c5f5d
(& maybe other typedefs that should be using this technique either got
missed or have regressed since that change was made)

This was noticed by a 1.4% clang.dwp regression due to
f4fb72e6d4cee1097e6606e66232fe55e793cd86 introducing more instantiations
of std::conditional - this change reduces that regression to 0.6% at
least.

I'm also looking at other instantiations caused by that change that
might be able to be addressed - but a quick grep shows ~200 "type"
typedefs missing _LIBCPP_NODEBUG, so maybe a systematic application of
the typedef might be suitable?

Differential Revision: https://reviews.llvm.org/D131082