[all-commits] [llvm/llvm-project] c76316: [llvm-mca] Fix class dominance warnings for parseC...

Michael Maitland via All-commits all-commits at lists.llvm.org
Tue Nov 22 12:31:39 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c7631606eb40d445615d3fc6f6599936463bac36
      https://github.com/llvm/llvm-project/commit/c7631606eb40d445615d3fc6f6599936463bac36
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2022-11-22 (Tue, 22 Nov 2022)

  Changed paths:
    M llvm/tools/llvm-mca/CodeRegionGenerator.h

  Log Message:
  -----------
  [llvm-mca] Fix class dominance warnings for parseCodeRegions

Fixes issue [59091](https://github.com/llvm/llvm-project/issues/59091).

`CodeRegionGenerator::parseCodeRegions` is implemented by `AsmCodeRegionGenerator`.
If it were to be implemented in `AnalysisRegionGenerator` or `InstrumentRegionGenerator`,
then `parseCodeRegions` from an `AsmAnalysisRegionGenerator` or `AsmInstrumentRegionGenerator`
object would be ambiguous. To solve this, `AsmAnalysisRegionGenerator` and
`AsmInstrumentRegionGenerator` qualify their call to `AsmCodeRegionGenerator::parseCodeRegions`.

Differential Revision: https://reviews.llvm.org/D138462




More information about the All-commits mailing list