[all-commits] [llvm/llvm-project] 8271aa: [libcxxabi] Always use thread_local for cxa_except...

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Tue Nov 22 12:30:13 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8271aa5335668a1dc62168a4e90b4554bd3a0ca7
      https://github.com/llvm/llvm-project/commit/8271aa5335668a1dc62168a4e90b4554bd3a0ca7
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-22 (Tue, 22 Nov 2022)

  Changed paths:
    M libcxxabi/src/cxa_exception_storage.cpp
    M libcxxabi/src/fallback_malloc.cpp
    M libcxxabi/src/fallback_malloc.h

  Log Message:
  -----------
  [libcxxabi] Always use thread_local for cxa_exception_storage

This was previously guarded by HAS_THREAD_LOCAL, which was never set by
CMake and had to be specified manually. Android has been setting this to
solve https://github.com/android/ndk/issues/1200 [1], but every compiler
and platform libc++abi supports should have thread_local by now, so we
can just get rid of the fallback implementation and simplify things
significantly (including removing the now unused fallback calloc).

[1] https://android-review.googlesource.com/c/toolchain/llvm-project/+/1285596

Reviewed By: #libc_abi, MaskRay, ldionne

Differential Revision: https://reviews.llvm.org/D138461




More information about the All-commits mailing list