[all-commits] [llvm/llvm-project] 244331: [X86] Fix scalar load latencies for WriteLoad sche...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sun Nov 6 04:22:28 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 244331ae833aaf33503bbd36890e704afb66a237
      https://github.com/llvm/llvm-project/commit/244331ae833aaf33503bbd36890e704afb66a237
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-11-06 (Sun, 06 Nov 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86ScheduleAtom.td
    M llvm/lib/Target/X86/X86ScheduleZnver1.td
    M llvm/lib/Target/X86/X86ScheduleZnver2.td
    M llvm/test/tools/llvm-mca/X86/Atom/resources-sse1.s
    M llvm/test/tools/llvm-mca/X86/Atom/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/Atom/resources-x87.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-clflushopt.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-clzero.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-prefetchw.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-sse1.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-x86_64.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-x87.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-clflushopt.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-clzero.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-prefetchw.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-sse1.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-x86_64.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-x87.s

  Log Message:
  -----------
  [X86] Fix scalar load latencies for WriteLoad scheduler class

Atom was missing a load latency value (so was defaulting to 1cy)

Znver1/Znver2 were using vector load latency values (which is what WriteFLoad*/WriteVecLoad* are for) instead of the scalar load latency value

TBH I'm not sure clflush/clzero/prefetch ops should be tagged as WriteLoad but at least this makes us more consistent




More information about the All-commits mailing list