[all-commits] [llvm/llvm-project] a78292: [mlir][SubElementInterfaces] Prefer calling the de...

River Riddle via All-commits all-commits at lists.llvm.org
Sat Nov 5 17:04:30 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a782922708af4e80bc9eaba977704420b6c765d9
      https://github.com/llvm/llvm-project/commit/a782922708af4e80bc9eaba977704420b6c765d9
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M mlir/include/mlir/IR/SubElementInterfaces.h

  Log Message:
  -----------
  [mlir][SubElementInterfaces] Prefer calling the derived get if possible

This allows for better supporting attributes/types that override the
default builders.


  Commit: 0e18d5ed21c829220849bb2adcc17b2f8077bbae
      https://github.com/llvm/llvm-project/commit/0e18d5ed21c829220849bb2adcc17b2f8077bbae
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M mlir/lib/IR/SubElementInterfaces.cpp

  Log Message:
  -----------
  [mlir][SubElements] Re-add null guards to better enable downstream adoption

We used to allow this, and it can break clients that still rely on it.


Compare: https://github.com/llvm/llvm-project/compare/f530e6e34ee1...0e18d5ed21c8


More information about the All-commits mailing list