[all-commits] [llvm/llvm-project] 2c7918: [X86] Cleanup WriteCvtSD2SS/WriteCvtPD2PS overrides

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sat Nov 5 08:51:15 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c79186bceeff8da4c7723039d5555b757aa6e91
      https://github.com/llvm/llvm-project/commit/2c79186bceeff8da4c7723039d5555b757aa6e91
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-11-05 (Sat, 05 Nov 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86SchedBroadwell.td
    M llvm/lib/Target/X86/X86SchedHaswell.td
    M llvm/lib/Target/X86/X86SchedIceLake.td
    M llvm/lib/Target/X86/X86SchedSkylakeClient.td
    M llvm/lib/Target/X86/X86SchedSkylakeServer.td
    M llvm/test/tools/llvm-mca/X86/Broadwell/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/Haswell/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/IceLakeServer/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/IceLakeServer/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/SkylakeClient/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/SkylakeClient/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/SkylakeServer/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/SkylakeServer/resources-sse2.s

  Log Message:
  -----------
  [X86] Cleanup WriteCvtSD2SS/WriteCvtPD2PS overrides

The WriteCvtSD2SS/WriteCvtPD2PS* classes were mostly unused as the models were needlessly overriding all instructions - in some cases the folded pattern overrides were entirely missing (but I've confirmed they just have an additional Port23 use)

There were a couple of typos (confirmed with Agner/uops.info) - Skylake/Icelake uses Port5+Port01 for XMM/YMM, Skylake uses Port5+Port05 for ZMM but Icelake uses Port5+Port0




More information about the All-commits mailing list