[all-commits] [llvm/llvm-project] c06454: [mlir][spirv] Do not truncate i/f64 -> i/f32 in SP...

[Jakub Kuderski via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c064545403917bedd450e07209e7870f1773f90f
      https://github.com/llvm/llvm-project/commit/c064545403917bedd450e07209e7870f1773f90f
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/include/mlir/Dialect/SPIRV/Transforms/SPIRVConversion.h
    M mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
    M mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRVPass.cpp
    M mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRVPass.cpp
    M mlir/lib/Conversion/TensorToSPIRV/TensorToSPIRVPass.cpp
    M mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
    M mlir/test/Conversion/ArithToSPIRV/arith-to-spirv-unsupported.mlir
    M mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir
    M mlir/test/Conversion/FuncToSPIRV/types-to-spirv.mlir

  Log Message:
  -----------
  [mlir][spirv] Do not truncate i/f64 -> i/f32 in SPIRVConversion

This truncation can be unexpected and break program behavior.
Dedicated emulation passes should be used instead.

Also rename pass options to "emulate-lt-32-bit-scalar-types".

Fixes: https://github.com/llvm/llvm-project/issues/57917

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D137115


  Commit: 6edb49eee2fd05c35642110f35766584428857b7
      https://github.com/llvm/llvm-project/commit/6edb49eee2fd05c35642110f35766584428857b7
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    M mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir

  Log Message:
  -----------
  [mlir][arith][spirv] Remove duplicate test cases

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D137166


Compare: https://github.com/llvm/llvm-project/compare/9a456b7ad312...6edb49eee2fd