[all-commits] [llvm/llvm-project] 3384f0: [llvm-objdump][Offload] Use common offload extract...

Joseph Huber via All-commits all-commits at lists.llvm.org
Thu Nov 3 14:19:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3384f05a2cdb96a2f106c234ae8a9d0e306717a4
      https://github.com/llvm/llvm-project/commit/3384f05a2cdb96a2f106c234ae8a9d0e306717a4
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
    M llvm/lib/Object/OffloadBinary.cpp
    R llvm/test/tools/llvm-objdump/Offloading/binary.test
    M llvm/test/tools/llvm-objdump/Offloading/content-failure.test
    A llvm/test/tools/llvm-objdump/Offloading/elf.test
    R llvm/test/tools/llvm-objdump/Offloading/warning.test
    M llvm/tools/llvm-objdump/OffloadDump.cpp

  Log Message:
  -----------
  [llvm-objdump][Offload] Use common offload extraction method

A previous patch introduced a common function used to extract offloading
binaries from an image. Therefore we no longer need to duplicate the
functionality in the `llvm-objdump` implementation. Functionally, this
removes the old warning behaviour when given malformed input. This has
been changed to a hard error, which is effectively the same.

This required a slight tweak in the linker wrapper to filter out the
user passing shared objects directly.

Reviewed By: tra

Differential Revision: https://reviews.llvm.org/D136796


  Commit: 8298f0b7b92e5e2ff8d547cd93863f094d13cb06
      https://github.com/llvm/llvm-project/commit/8298f0b7b92e5e2ff8d547cd93863f094d13cb06
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M llvm/lib/Object/OffloadBinary.cpp
    A llvm/test/tools/llvm-objdump/Offloading/coff.test
    M llvm/test/tools/llvm-objdump/Offloading/non-elf.test
    M llvm/tools/llvm-objdump/OffloadDump.cpp

  Log Message:
  -----------
  [Binary] Support extracting offloading files from COFF

This patch adds initial support for extracting offloading binaries from
`COFF` objects. This is a first step to allow building offloading files
on Windows targets with the new driver.

Depends on D136796

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D136855


Compare: https://github.com/llvm/llvm-project/compare/247dedea4e03...8298f0b7b92e


More information about the All-commits mailing list