[all-commits] [llvm/llvm-project] dc9854: [JITLink] Fix check-line in Windows X86 COFF COMDA...

[Stefan Gränitz via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dc9854d4e91e5ede86e8ebb9bfea244cf494e8c6
      https://github.com/llvm/llvm-project/commit/dc9854d4e91e5ede86e8ebb9bfea244cf494e8c6
  Author: Stefan Gränitz <stefan.graenitz at gmail.com>
  Date:   2022-11-03 (Thu, 03 Nov 2022)

  Changed paths:
    M llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_plus_strong.s

  Log Message:
  -----------
  [JITLink] Fix check-line in Windows X86 COFF COMDAT test

This test caught my attention because it's the only one in JITLink that XFAILs. Running it in isolation showed that the output doesn't meet the CHECK-LINES, i.e. the block address didn't match:

```
error: CHECK-NEXT: expected string not found in input
  CHECK-NEXT: block 0xfff02000 size = 0x00000001, align = 16, alignment-offset = 0

<stdin>:22:2: note: possible intended match here
              block 0xfff01000 size = 0x00000001, align = 16, alignment-offset = 0
```

Though, that doesn't appear to be the reason the test XFAILs. What we really want to check here is that llvm-jitlink doesn't fail with a duplicate section error yet.
In order to avoid issues like this in the future we can match a placeholder to check for some valid address within the slab (64Kb == last 4 digits).

The patch also drops the duplicate -noexec argument, removes an empty RUN-line, fixes indentation and adds a newline at EOF.

Reviewed By: sunho

Differential Revision: https://reviews.llvm.org/D137148