[all-commits] [llvm/llvm-project] f33173: [clang][modules][deps] System module maps might no...

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f33173acd6875fa86448bb6d91bdac8f1296510a
      https://github.com/llvm/llvm-project/commit/f33173acd6875fa86448bb6d91bdac8f1296510a
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M clang/lib/Serialization/ASTWriter.cpp
    M clang/test/ClangScanDeps/modules-implicit-dot-private.m
    M clang/test/ClangScanDeps/modules-incomplete-umbrella.c
    A clang/test/ClangScanDeps/modules-redefinition.m

  Log Message:
  -----------
  [clang][modules][deps] System module maps might not be affecting

The dependency scanner relies on the module map filtering logic in `ASTWriter`. The algorithm currently considers all system module maps affecting, which is not only sub-optimal, but can also cause failures when building a module explicitly (see attached test case).

This patch applies the same filtering logic to system module maps.

Reviewed By: Bigcheese

Differential Revision: https://reviews.llvm.org/D136007