[all-commits] [llvm/llvm-project] 72ba24: [PatternMatch] don't match a scalar select of bool...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Tue Nov 1 11:50:38 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 72ba2489f2c7b0a911bd23e50aaaca6eae9a183e
      https://github.com/llvm/llvm-project/commit/72ba2489f2c7b0a911bd23e50aaaca6eae9a183e
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-11-01 (Tue, 01 Nov 2022)

  Changed paths:
    M llvm/include/llvm/IR/PatternMatch.h
    M llvm/unittests/IR/PatternMatch.cpp

  Log Message:
  -----------
  [PatternMatch] don't match a scalar select of bool vectors as a logical-and or logical-or

Most folds based on these matchers already check to make sure the
condition type is the same as the select type, and it seems unlikely
that a fold would want to handle a scalar-select-of-vectors pattern
(there are no regression tests for it).

This is a preliminary step for fixing #issue 58552. The fold(s)
responsible for that crash (D101807, D101375) don't use the matchers
yet, but they probably should.

Differential Revision: https://reviews.llvm.org/D137170




More information about the All-commits mailing list