[all-commits] [llvm/llvm-project] aa887f: [InstCombine] add test for branch on logical-and; NFC

Sanjay Patel via All-commits all-commits at lists.llvm.org
Mon Oct 31 14:39:45 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aa887ff3f43aeaeb76d6be176d0ed67eb414eff8
      https://github.com/llvm/llvm-project/commit/aa887ff3f43aeaeb76d6be176d0ed67eb414eff8
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/branch.ll

  Log Message:
  -----------
  [InstCombine] add test for branch on logical-and; NFC

More coverage for the change 115d2f69a515cd756fa51 as
suggested in post-commit feedback.

Given that the transform is canonicalized with another
'not' op, we should adjust the use checks and create
that form directly.


  Commit: 1f8ac37e2d50b0175225a0d8f3f5003f64b46b89
      https://github.com/llvm/llvm-project/commit/1f8ac37e2d50b0175225a0d8f3f5003f64b46b89
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
    M llvm/test/Transforms/InstCombine/branch.ll

  Log Message:
  -----------
  [InstCombine] adjust branch on logical-and fold

The transform was just added with:
115d2f69a515cd756fa51
...but as noted in post-commit feedback, it was
confusingly coded. Now, we create the final
expected canonicalized form directly and put
an extra use check on the match, so we should
not ever end up with more instructions.


Compare: https://github.com/llvm/llvm-project/compare/e3ad2ca85f59...1f8ac37e2d50


More information about the All-commits mailing list