[all-commits] [llvm/llvm-project] 179978: [mlir][arith][spirv] Hard fail in `-convert-arith-...

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Mon Oct 31 14:01:58 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 179978d7b8ec00291401d2ec49fc0a55e7f7bfb3
      https://github.com/llvm/llvm-project/commit/179978d7b8ec00291401d2ec49fc0a55e7f7bfb3
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2022-10-31 (Mon, 31 Oct 2022)

  Changed paths:
    M mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp
    M mlir/lib/Conversion/SPIRVCommon/Pattern.h
    A mlir/test/Conversion/ArithToSPIRV/arith-to-spirv-unsupported.mlir
    M mlir/test/Conversion/ArithToSPIRV/arith-to-spirv.mlir

  Log Message:
  -----------
  [mlir][arith][spirv] Hard fail in `-convert-arith-to-spirv`

Turn legalization failures into hard failures to make sure that we do
not miss conversion pattern application failures.

Add a message on type conversion failure.

Move unsupported cases into a separate test file.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D137102




More information about the All-commits mailing list