[all-commits] [llvm/llvm-project] 19ac69: [llvm-objdump] Add --no-print-imm-hex to new tests...

Daniel Thornburgh via All-commits all-commits at lists.llvm.org
Sun Oct 30 13:36:32 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19ac69320846e6d741edddff422985e0e39492f2
      https://github.com/llvm/llvm-project/commit/19ac69320846e6d741edddff422985e0e39492f2
  Author: Daniel Thornburgh <mysterymath at gmail.com>
  Date:   2022-10-30 (Sun, 30 Oct 2022)

  Changed paths:
    M llvm/test/MC/AArch64/SME2/smlall.s
    M llvm/test/MC/AArch64/SME2/smlsll.s
    M llvm/test/MC/AArch64/SME2/sumlall.s
    M llvm/test/MC/AArch64/SME2/umlall.s
    M llvm/test/MC/AArch64/SME2/umlsll.s
    M llvm/test/MC/AArch64/SME2/usmlall.s

  Log Message:
  -----------
  [llvm-objdump] Add --no-print-imm-hex to new tests depending on it.

This prepares for an upcoming change to make --print-imm-hex the default
behavior of llvm-objdump. A few newly-added tests were missed the first
time around.

See D136972 for details.


  Commit: cc2457ca1bbdddefc09d72f889bc0389c90a831e
      https://github.com/llvm/llvm-project/commit/cc2457ca1bbdddefc09d72f889bc0389c90a831e
  Author: Daniel Thornburgh <mysterymath at gmail.com>
  Date:   2022-10-30 (Sun, 30 Oct 2022)

  Changed paths:
    M llvm/docs/CommandGuide/llvm-objdump.rst
    M llvm/docs/ReleaseNotes.rst
    M llvm/test/tools/llvm-objdump/X86/print-imm-hex.s
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  -----------
  [llvm-objdump] Set --print-imm-hex by default.

This was previously attempted in 2016 by colinl's D18770, but LLD tests
were missed, which caused the change to be reverted.

Setting --print-imm-hex by default brings llvm-objdump's behavior closer
in line with objdump, and it makes it easier to read addresses and
alignment from the disassembly. It may make non-address immediates
harder to interpret, but it still seems the better default, barring more
context-sensitive base selection logic.

Differential Revision: https://reviews.llvm.org/D136972


Compare: https://github.com/llvm/llvm-project/compare/3f82caf7b165...cc2457ca1bbd


More information about the All-commits mailing list