[all-commits] [llvm/llvm-project] ddec89: [clang][Interp][NFC] Use right visit() function

Timm Bäder via All-commits all-commits at lists.llvm.org
Fri Oct 28 08:45:38 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ddec89670dd873a293c958a8fc7f778e3cc4297b
      https://github.com/llvm/llvm-project/commit/ddec89670dd873a293c958a8fc7f778e3cc4297b
  Author: Timm Bäder <tbaeder at redhat.com>
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
    M clang/lib/AST/Interp/ByteCodeExprGen.cpp

  Log Message:
  -----------
  [clang][Interp][NFC] Use right visit() function

visit (lowercase V) sets DiscardValue to false and calls Visit
(uppercase V). So we can't just call Visit (uppercase V) ourselves,
since then we aren't handling DiscardValue correctly.
This is currently irrelevant but will make a difference later.

Also, the naming isn't my fault and might change later.




More information about the All-commits mailing list