[all-commits] [llvm/llvm-project] 7d4d25: [lldb-vscode] Don't call SBValue.GetError after ge...

Jorge Gorbe Moya via All-commits all-commits at lists.llvm.org
Thu Oct 27 15:05:58 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7d4d25c42a682ec5abcc008225268a6ce82673f3
      https://github.com/llvm/llvm-project/commit/7d4d25c42a682ec5abcc008225268a6ce82673f3
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2022-10-27 (Thu, 27 Oct 2022)

  Changed paths:
    M lldb/tools/lldb-vscode/JSONUtils.cpp

  Log Message:
  -----------
  [lldb-vscode] Don't call SBValue.GetError after generating a summary.

In some occasions, SBValue::GetError can invalidate its cached
`m_summary_str` member. This in turn invalidates any StringRef variables
pointing to it.

Differential Revision: https://reviews.llvm.org/D136890




More information about the All-commits mailing list