[all-commits] [llvm/llvm-project] 7bbd0f: Revert "[lldb-vscode] Send Statistics Dump in term...

[kusmour via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7bbd0fba986c241162b77b7e424ad82bc7e17b41
      https://github.com/llvm/llvm-project/commit/7bbd0fba986c241162b77b7e424ad82bc7e17b41
  Author: Wanyi Ye <wanyi at fb.com>
  Date:   2022-10-26 (Wed, 26 Oct 2022)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    R lldb/test/API/tools/lldb-vscode/terminated-event/Makefile
    R lldb/test/API/tools/lldb-vscode/terminated-event/TestVSCode_terminatedEvent.py
    R lldb/test/API/tools/lldb-vscode/terminated-event/foo.cpp
    R lldb/test/API/tools/lldb-vscode/terminated-event/foo.h
    R lldb/test/API/tools/lldb-vscode/terminated-event/main.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp
    M lldb/tools/lldb-vscode/JSONUtils.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  Revert "[lldb-vscode] Send Statistics Dump in terminated event"

This reverts commit c8a26f8c6de30dbd814546f02e4c89a4fcb2b4ef.

Returning full statistics result in "terminated" (DAP) event could result in delay in the UI when debugging from VSCode.

If the program run to exit and debug session terminates. The DAP event order will be: exited event --> terminateCommands --> terminated event --> disconnect request --> disconnect response.

The debugging UI in VSCode corresponds to "disconnect" request/response. If the terminated event is taking long to process, the IDE won't quit debugging UI until it's done.

For big binary (tested example has 29 GB of debug info), it can cause ~15s delay in terminated event itself. And the UI could take ~20s to reflect.

This may cause confusion in debug sessions. We should persuit a more lightweight return or other solution to return such info.