[all-commits] [llvm/llvm-project] 51effa: Fix exception description in lldb-vscode

jeffreytan81 via All-commits all-commits at lists.llvm.org
Tue Oct 25 13:24:42 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 51effa57818bf937fb7c889b8f567c146bb4eefe
      https://github.com/llvm/llvm-project/commit/51effa57818bf937fb7c889b8f567c146bb4eefe
  Author: Jeffrey Tan <jeffreytan at fb.com>
  Date:   2022-10-25 (Tue, 25 Oct 2022)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
    A lldb/test/API/tools/lldb-vscode/exception/Makefile
    A lldb/test/API/tools/lldb-vscode/exception/TestVSCode_exception.py
    A lldb/test/API/tools/lldb-vscode/exception/main.cpp
    M lldb/tools/lldb-vscode/JSONUtils.cpp

  Log Message:
  -----------
  Fix exception description in lldb-vscode

There is a bug in lldb-vscode that only shows stop reason ("exception") in
stopped event without showing the stop description of thrown exception. This
causes VSCode UI to only show "Paused on Exception" general message in
callstack window UI.

This patch fixes the bug so that VSCode callstack will show the detailed
exceptioni description, like "signal SIGABRT" or "EXC_BAD_ACCESS..." which
aligns with command line lldb experience.

I use C++ exception in testcase because the hardware exception description is
platform dependent and hard to verify.

Differential Revision: https://reviews.llvm.org/D136295




More information about the All-commits mailing list