[all-commits] [llvm/llvm-project] 01b814: [AMDGPU] Fix delay alu for VOPD with src2acc

Joe Nash via All-commits all-commits at lists.llvm.org
Tue Oct 25 10:11:37 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 01b8140d3aac50ad4c00246bddab8646a61016ed
      https://github.com/llvm/llvm-project/commit/01b8140d3aac50ad4c00246bddab8646a61016ed
  Author: Joe Nash <Joseph.Nash at amd.com>
  Date:   2022-10-25 (Tue, 25 Oct 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h
    M llvm/lib/Target/AMDGPU/VOP2Instructions.td
    M llvm/lib/Target/AMDGPU/VOPDInstructions.td
    M llvm/test/CodeGen/AMDGPU/vopd-combine.mir
    R llvm/test/CodeGen/AMDGPU/vopd-fmac-delay.mir
    A llvm/test/CodeGen/AMDGPU/vopd-src2acc-delay.mir
    M llvm/test/MC/AMDGPU/gfx11_asm_vopd_errs.s

  Log Message:
  -----------
  [AMDGPU] Fix delay alu for VOPD with src2acc

V_FMAC_F32 and V_DOT2C_F32_F16 have a dummy src2 operand tied to vdst to
inform passes that the instructions read the dst operand. The VOPD
versions of these instructions lacked the dummy operand, which was a
problem for inserting s_delay_alu.
Introduce the dummy src2 operand on the VOPD versions, and fix the VOPD operand
tracking logic to account for it.

Reviewed By: dp

Differential Revision: https://reviews.llvm.org/D136629




More information about the All-commits mailing list