[all-commits] [llvm/llvm-project] 048772: [PGO] Make emitted symbols hidden

[Alex Brachet via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 04877284b4592e9286cab43467662c1b4ff81861
      https://github.com/llvm/llvm-project/commit/04877284b4592e9286cab43467662c1b4ff81861
  Author: Alex Brachet <abrachet at google.com>
  Date:   2022-10-24 (Mon, 24 Oct 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/Darwin.cpp
    M clang/test/Driver/darwin-ld.c
    M compiler-rt/lib/profile/InstrProfilingNameVar.c
    M compiler-rt/lib/profile/InstrProfilingVersionVar.c
    M llvm/lib/ProfileData/InstrProf.cpp
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    M llvm/test/Transforms/PGOProfile/branch1.ll
    M llvm/test/Transforms/PGOProfile/branch2.ll
    M llvm/test/Transforms/PGOProfile/comdat_internal.ll
    M llvm/test/Transforms/PGOProfile/criticaledge.ll
    M llvm/test/Transforms/PGOProfile/instr_entry_bb.ll
    M llvm/test/Transforms/PGOProfile/landingpad.ll
    M llvm/test/Transforms/PGOProfile/loop1.ll
    M llvm/test/Transforms/PGOProfile/loop2.ll
    M llvm/test/Transforms/PGOProfile/lto_cspgo_gen.ll
    M llvm/test/Transforms/PGOProfile/single_bb.ll
    M llvm/test/Transforms/PGOProfile/switch.ll
    M llvm/test/Transforms/PGOProfile/thinlto_cspgo_gen.ll

  Log Message:
  -----------
  [PGO] Make emitted symbols hidden

This was reverted because it was breaking when targeting Darwin which
tried to export these symbols which are now hidden. It should be safe
to just stop attempting to export these symbols in the clang driver,
though Apple folks will need to change their TAPI allow list described
in the commit where these symbols were originally exported
https://github.com/llvm/llvm-project/commit/f5380185623be243ba0f1b18d4bd594ac5cc7163

Bug: https://github.com/llvm/llvm-project/issues/58265

Differential Revision: https://reviews.llvm.org/D135340