[all-commits] [llvm/llvm-project] 5de73d: [scudo] Change region size from 1 MB to 2 MB in tests

ChiaHungDuan via All-commits all-commits at lists.llvm.org
Mon Oct 17 13:23:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5de73d27bd6b9140978b376b34ef3a7231df9aa9
      https://github.com/llvm/llvm-project/commit/5de73d27bd6b9140978b376b34ef3a7231df9aa9
  Author: Chia-hung Duan <chiahungduan at google.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
    M compiler-rt/lib/scudo/standalone/tests/primary_test.cpp

  Log Message:
  -----------
  [scudo] Change region size from 1 MB to 2 MB in tests

In SizeClassAllocator64, the RegionBeg is determined by RegionBase +
random offset. The offset is n pages, where n is a random number less or
equal to 16. However, on certain platforms which have large page size,
it may end up immediately OOM without mapping any block pages. For
example,

PageSize = 64 KB, RegionSize = 1 MB

Suppose the random number n is 16, then the random offset will be
64 * 16 = 1024 KB which is equal to the RegionSize.

On most platforms we don't have such large page size and we have
different PRNG(pseudo random number generator) behaviors, thus we didn't
hit any failures before. Given that this now only affects the tests,
only increase the region size is enough.

Will revisit the logic of calculating the random offset.

Differential Revision: https://reviews.llvm.org/D136025




More information about the All-commits mailing list